-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reorg: modular file reorganization of C source code - v9 #9973
Conversation
AppLayerProtoDetectPPRegister(IPPROTO_TCP, | ||
"85", | ||
ALPROTO_FTP, | ||
7, 15, | ||
STREAM_TOSERVER, | ||
ProbingParserDummyForTesting, NULL); | ||
AppLayerProtoDetectPPRegister(IPPROTO_TCP, "80", ALPROTO_SMB, 5, 6, STREAM_TOSERVER, | ||
ProbingParserDummyForTesting, NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compressions like this by clang-format are what caused the drop in line count.
ERROR: ERROR: QA failed on build_dbg. Pipeline 16881 |
looks like git already picked it up below but
|
Yes, this work is non-rebaseable. |
.dirstamp files are a build artifact created when GNU autoconf projects have files spread over multiple directories.
Autoconf used to generate a config.h, but it doesn't anymore, and this ends up ignoring files like util/config.h, which we do not want to happen.
Disable clang-format around byte arrays, as they have likely been manually formatted into something that makes sense for humans. This has been scripted.
Information: QA ran without warnings. Pipeline 16888 |
Continuation of #9960.
This is the same is #9960, but fixes the util migration as a file went missing. Also conforms to CI's idea of clang-format.
Some tests still fail:
Next steps:
app-layer/
output/eve
output/
util/
util/mpm/
sources/
(or capture?)detect/